logo_kerberos.gif

Coding style/Transition strategies

From K5Wiki
Jump to: navigation, search

Parts of the existing source tree are not conforming to our coding style. These inconsistencies can create barriers to entry for new contributors. This page outlines some transition strategies.

Contents

Implementation of transition

Multiple phases. Consider batching changes.

  • Tabs to spaces (and related whitespace issues like end-of-line whitespace)
    • Mark with emacs file variables
    • Confirm that this worked by checking if "diff -w" shows no changes
  • Reindent
    • Mark with emacs file variables
    • As this may change linebreaks, requires a little more review

Exempt code

Sun-origin code:

  • src/lib/rpc
  • src/include/gssrpc

BSD-origin code:

  • src/appl/bsd
  • src/appl/telnet
  • src/appl/gssftp
  • src/plugins/kdb/db2/libdb2

Whitespace

To mark files as having all tabs expanded to space characters, place the following Emacs mode/local-variable line at the very top of the file:

/* -*- mode: c; indent-tabs-mode: nil -*- */

Indentation

To mark files as having indentation conforming to our coding style, add c-basic-offset: 4 to the local variable line:

/* -*- mode: c; c-basic-offset: 4; indent-tabs-mode: nil -*- */

Some emacs customizations for automatically using the "krb5" c style are in src/util/krb5-c-style.el (raw | annotated | history); putting a reference to that style in the local variable line would not be friendly to developers who do not define that style in their .emacs files, so we will use the combination of c-basic-offset and indent-tabs-mode instead.

For BSD-derived code, use

/* -*- mode: c; c-file-style: "bsd"; indent-tabs-mode: t -*- */

as the "bsd" style is already defined by most implementations of emacs CC Mode.

Vim?

Do we want to add file modelines for vim? Some versions of vim had vulnerabilities in handling of modelines.

Personal tools