Difference between revisions of "Talk:Project policy"

Revision as of 12:51, 4 April 2008

I don't see a link from the project policy on the k5wiki to code change/integration policy. So I do not know if a code review is necessary and what sort of testing is expected.

There is not a formalized code review policy. Certainly requesting specific code review as part of the community review of a project would be fine. --SamHartman 12:08, 4 April 2008 (EDT)

Submitting a project for review needs work

The "Submitting a project for review" section indicates the submitter should:

To start the review period :

   1. Replace {{project-early}} with {{project-review|end_of_review_date}}
   2. Add {{subst:project-vote}} at the bottom of the project page.
   3. Send mail to krbdev@mit.edu including:

But after saving the project page after following steps 1 & 2, this text appears on the project page:

   An announcement has been sent to krbdev@mit.edu starting a review of
   this project. That review will conclude on 2008-04-18.

This is confusing as it sounds like step 3 was done automatically by the wiki. If the wiki is sending out notification automatically (and I think it should) then step 3 should be removed.

The Wiki cannot send out mail. The procedure is correct, but the text on the project page assumes that you actually follow the directions and send the mail. --SamHartman 12:08, 4 April 2008 (EDT)

I think the wording of the project-review template needs to be changed to avoid the ambiguity. Something like:

   The project owner should have sent an announcement to krbdev@mit.edu starting a review of
   this project. That review will conclude on 2008-04-18.

--Will Fiveash 12:42, 4 April 2008 (CDT)

I think updating the policy to make it clear that you need to send the mail but that the page will say that mail is sent would be good. I think that updating the template will be more confusing than desirable. I'll also update the template docs. --SamHartman 13:51, 4 April 2008 (EDT)