Projects/Policy refcount elimination - Revision history

Ghudson at 06:08, 15 March 2013

2013-03-15T06:08:35Z

Ghudson: /* Code changes */

2013-01-09T05:59:26Z

‎Code changes

Ghudson: /* Testing */

2013-01-09T00:47:15Z

‎Testing

Ghudson: /* Testing */

2013-01-09T00:34:10Z

‎Testing

Ghudson: /* Code changes */

2013-01-08T17:28:10Z

‎Code changes

Ghudson at 17:19, 7 January 2013

2013-01-07T17:19:35Z

Ghudson at 07:16, 7 January 2013

2013-01-07T07:16:37Z

Ghudson at 07:15, 7 January 2013

2013-01-07T07:15:37Z

Ghudson: /* Code changes */

2013-01-07T07:02:08Z

‎Code changes

Ghudson: /* Background */

2013-01-04T21:03:50Z

‎Background

@@ Line 1: / Line 1: @@
-{{project-target|1.12}}
+{{project-rel|1.12}}
 This project corresponds to {{bug|7385}}, which proposes to eliminate the use of the policy reference count field.
@@ Line 73: / Line 73: @@
 * Authenticating (with preauth) against a principal referencing a nonexistent policy
 * Creating the policy (formerly nonexistent) referenced by a principal, and checking that it is now enforced
 == Release notes ==

@@ Line 56: / Line 56: @@
 * kadmin_addprinc, kadmin_modprinc: If the principal's policy reference is being set, check if the policy exists and warn if it does not.
-* kadmin_getpol: Don't output policy_refcnt in long-form output.  In terse output, always output 0.
+* kadmin_getpol: Don't output policy_refcnt in long-form output, but annotate the policy name if it does not exist.  In terse output, output 0 in place of policy_refcnt.
 * populate_krb5_db_entry (in LDAP KDB module): don't return an error if the entry's policy cannot be found.

@@ Line 66: / Line 66: @@
 The kadm5 dejagnu test suite will need to be modified to allow the new semantics.  t_kdb.py may need adjusting as well.
-The two Python scripts t_lockout.py and t_pwhist.py will be consolidated into a new script t_policy.py.  In addition to the current lockout and password history tests, this new script will test:
+The Python scripts t_lockout.py, t_pwhist.py, and t_allowed_keysalts.py will be consolidated into a new script t_policy.py.  Tests will be added to this script for:
 * Creation of a principal with a nonexistent policy

@@ Line 69: / Line 69: @@
 * Creation of a principal with a nonexistent policy
-* Modification of a principal to reflect a nonexistent policy
+* Modification of a principal to refer to a nonexistent policy
 * Deleting a policy referenced by a principal
 * Fetching a principal (with getprinc) referencing a nonexistent policy

← Older revision		Revision as of 17:28, 8 January 2013
Line 53:		Line 53:

	* process_k5beta7_policy, process_r1_8_policy, process_r1_11_policy: ignore the policy_refcnt values read from the dump instead of storing them into the entry.		* process_k5beta7_policy, process_r1_8_policy, process_r1_11_policy: ignore the policy_refcnt values read from the dump instead of storing them into the entry.
		+
		+	* kadmin_addprinc, kadmin_modprinc: If the principal's policy reference is being set, check if the policy exists and warn if it does not.

	* kadmin_getpol: Don't output policy_refcnt in long-form output. In terse output, always output 0.		* kadmin_getpol: Don't output policy_refcnt in long-form output. In terse output, always output 0.

← Older revision		Revision as of 17:19, 7 January 2013
Line 1:		Line 1:
−	{{project-~~early~~}}	+	{{project-target\|1.12}}
		+	{{project-review\|2012-01-14}}

	This project corresponds to {{bug\|7385}}, which proposes to eliminate the use of the policy reference count field.		This project corresponds to {{bug\|7385}}, which proposes to eliminate the use of the policy reference count field.

@@ Line 1: / Line 1: @@
 {{project-early}}
-This project corresponds to {{bug|7385}}, which proposes to elminate the use of the policy reference count field.
+This project corresponds to {{bug|7385}}, which proposes to eliminate the use of the policy reference count field.
 == Background ==

@@ Line 35: / Line 35: @@
 == Code changes ==
-The following units of code would be affected by this project:
+The following units of code are affected by this project:
 * kadm5_policy_ent_rec, osa_policy_ent_rec: add comments indicating that policy_refcnt is no longer maintained or used.
-* kadm5_create_principal_3, kadm5_modify_principal, kadm5_delete_principal: stop maintaining policy_refcnt fields of policies referenced by the old or new principal entries.
+* kadm5_create_principal_3, kadm5_modify_principal, kadm5_delete_principal: stop maintaining policy_refcnt fields of policies referenced by the old or new principal entries.  Stop returning an error if the new principal entry references a nonexistent policy (also in apply_keysalt_policy).
-* kadm5_create_policy_internal, kadm5_modify_policy_internal: stop checking mask & KADM5_REF_COUNT and setting pent.policy_refcnt.  These functions can be folded into their callers (kadm5_create_policy and kadm5_modify_policy).
+* kadm5_create_policy_internal, kadm5_modify_policy_internal: stop checking mask & KADM5_REF_COUNT and setting pent.policy_refcnt.  These functions can be folded into their callers (kadm5_create_policy and kadm5_modify_policy respectively).
 * kadm5_delete_policy: stop checking policy_refcnt.
@@ Line 49: / Line 49: @@
 * kadm5_get_policy: set entry->policy_refcnt to 0 instead of propagating it from the KDB entry.
 * kadmin_getpol: Don't output policy_refcnt in long-form output.  In terse output, always output 0.
 == Testing ==

@@ Line 15: / Line 15: @@
 * Historically, there have been bugs such as {{bug|7384}} allowing policy reference counts to become out of sync on slaves, and there are probably still bugs of that nature.  If a slave is promoted to a master with inconsistent reference counts, the new master could incorrectly forbid or allow a policy deletion operation.
-* {{bug|7522}} proposes to propagat policy changes over iprop (which currently has no way to marshal them) by forcing a full propagation whenever a policy changes.  Frequent changes to policy reference counts would render this prohibitively expensive.  Ignoring policy changes which only change the policy_refcnt field would allow reference count fields to become inconsistent on slaves.
+* {{bug|7522}} proposes to propagate policy changes over iprop (which currently has no way to marshal them) by forcing a full propagation whenever a policy changes.  Frequent changes to policy reference counts would render this prohibitively expensive.  Ignoring policy changes which only change the policy_refcnt field would allow reference count fields to become inconsistent on slaves.
 * Policy deletion is a rare operation.  Fundamentally, it does not make sense to impose an extra burden on principal modifications for the sake of such a rare operation.